what do you all consider the best weapon for a valkyrie? or lord? or ninja?
lots of different possibilities...
ranged or short or extended

I have a preference to use characters' bonus stats wherever possible, and that reflects in my choices.

Lord's easy: Dual Weapon bonus + Mauler (Mace bonus) + Diamond Eyes is one of the deadliest melee builds.
Ninja, if Faerie, Cane. Else maybe Light and Ench Wak or Winterwand (esp. for the Snowballs) Of course, the best chars for Swords are Samurai and Fighter, but then Fighter has a generic fighting bonus, so they make the most of anything. Monk for Martial Arts, that's what the bonus is for.
Haven't played any Valks; most Polearms have big Initiative malus, and the best fast one (Dread Spear) has its own bonus, so i don't bother with Valks, but i suppose Raven's Bill and Dread are good choices...if i stuck with using the bonus. Else, (esp if you dual-wield) Sword and maybe Mace (DE) or Dagger (Stiletto, maybe Canezou)
To Roleplay a Valk, i suppose, if not a Spear then a double-axe, like Ripper...

I never used the Vampire Chain befor so I gave it to my dwarf fighter and set him all alone up front and let him take all the melee damage, then on his attack, he would drain the life points back and be at full health at the end of every round. It was pretty sweet, Not bad damage and 4 swings per round was good enough for me.

For lord a sword primary/ mace secondary is the go...
Maybe later swapping to mauler/diamond eyes.

Earlier on you can do diamond epee and diamond eyes or fang and diamond eyes.
Both good combo's.

The problem with dual mace-ing from the beginning is a lack of good maces, unless u risk a run to get the diamond eyes.
THe diamond epee is gotten early in arnika and has good init and to hit stats.

There are several choices for polearm for the Valk. I like the Dread Spear which Bela sells and the Burning and Spear of Death are good too.